Closed ericf closed 10 years ago
Note that in commit 5c0df8 (no PR?) that the factory is called multiple times. This means that different module systems will have different copies of the handlers. This is probably OK because there isn't much state (caches, etc) shared between handlers anyway.
yeah, I thought that was weird. Why should we care about using intl-messageformat from the require?
@drewfish in a conversation with @ericf we talked thru getting all these packages to be ES module that transpile to the different module systems, and that will help I think, but we need to continue that conversation.
Oh, I meant to push to my fork. Sorry, I did a Git screwup.
I can revert this and on master and move it to a proper PR.
@drewfish @caridy reverted on master and created PR #25 for this.
This has been resolved. The Node.js version now depends on intl-messageformat
, while the browser version has all its dependencies bundled together.
Both the AMD and Node.js parts of the UMD wrapper should treat
intl-messageformat
as a dependency since it's not a polyfill.