search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Usage docs update. #30

Closed triptych closed 10 years ago

triptych commented 10 years ago

The usage docs were missing from handlebars-helper-intl. I modeled these after the dust-helper-intl usage docs.

yahoocla commented 10 years ago

CLA is valid!

clarle commented 10 years ago

This is cool - I'd definitely like to see an example of using subexpressions like we do in full-intl though:

https://github.com/ericf/full-intl/blob/master/views/layouts/main.handlebars#L7

clarle commented 10 years ago

:+1:, looks good to me!

ericf commented 10 years ago

Overall I worry that these docs are focusing too much on having redundant and examples showing basic usage of the Intl JavaScript APIs via our Handlebars wrappers.

I don't think people will be able to read the README and know where to start. I also don't think it will make them successful at using this package in a real setting as it shows nothing about rendering templates and setting up the rendering context.

We need to step back and re-focus this README and the other template engine READMEs on helping people use this stuff in a real way and not re-iterate basic Intl JavaScript API usage in these, since that's available on MDN.

I think it's safe to ignore my specific line comments, because I think we need to step back at this point instead of making the smaller changes based on the line comments.

ericf commented 10 years ago

Decision is to not merge this as-is.

triptych commented 10 years ago

Closing due to comments above.