search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Expose `IntlMessageFormat` in dist bundle #39

Closed ericf closed 10 years ago

ericf commented 10 years ago

Closes #38

yahoocla commented 10 years ago

CLA is valid!

caridy commented 10 years ago

isn't easier to update the grunt task?

do we need to update helpers.js to reexport IntlMessageFormat?

ericf commented 10 years ago

isn't easier to update the grunt task?

Not sure what you're proposing we do to the Grunt task…

do we need to update helpers.js to reexport IntlMessageFormat?

No. Why would you think we need to? The transpiler is smart enough to figure it out when creating the bundle format. You should look at how this project's module are structured, I changed it from how it was last week.

caridy commented 10 years ago

my point is, if we will use src/helpers.js as the main entry point to the graph, then it should export two thing: registerWith and IntlMessageFormat. today, it only does registerWith.

once we sort that out, we can eliminate main.js, and we can add a new option to the grunt pkg to support exporting all bindings rather than default export or an explicit named export.

ericf commented 10 years ago

Closing in favor of #40.