formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Refactor for IntlRelativeFormat and CLDR data #45

Closed ericf closed 9 years ago

ericf commented 9 years ago

This is a fairly major refactor of this package to bring it inline with react-intl. The changes include the following:

Since the locale data has been separated from the runtime, to use this package, a developer must now include two scripts on the page; e.g., for French:

<script src="handlebars-intl/handlebars-intl.min.js"></script>
<script src="handlebars-intl/locale-data/fr.js"></script>

Making these changes brings down the total size of this library — when used in the browser, bundled with its dependencies — to 7.1k gz.

caridy commented 9 years ago

LGTM

juandopazo commented 9 years ago

I like that we're trying to throw useful errors :thumbsup: