search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Add browser smoke tests in Saucelabs #46

Closed juandopazo closed 9 years ago

juandopazo commented 9 years ago

This will only test in browsers when new commits are pushed to master. It won't test pull requests in Saucelabs because it's too slow.

Note: these browser tests fail because of a bug in Intl.js.

This should not be merged until https://github.com/andyearnshaw/Intl.js/issues/75 is fixed.

yahoocla commented 9 years ago

CLA is valid!

caridy commented 9 years ago

LGTM

ericf commented 9 years ago

It won't test pull requests in Saucelabs because it's too slow.

This is the right thing to do because Travis doesn't support the secure tokens feature on PRs anyways.

juandopazo commented 9 years ago

Removed the pretest script. Please don't merge this until the Intl bug is fixed.

juandopazo commented 9 years ago

I changed the npm test script so that it doesn't try to run Sauce tests. I think this is better for local development.

ericf commented 9 years ago

@juandopazo please merge this when you think it's ready.

juandopazo commented 9 years ago

Yup! I'll handle it.