formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Use Intl.js Polyfill as `Intl` mock in unit tests #50

Closed ericf closed 9 years ago

ericf commented 9 years ago

Formatted output differs across implementations; e.g. IE11 adds bidi chars: http://stackoverflow.com/questions/25574963/ies-tolocalestring-has-strange-characters-in-results

Therefore makes it difficult to unit test just these helpers. In order to overcome these problems, we can simply force the use of the Intl.js Polyfill as an Intl mock.

yahoocla commented 9 years ago

CLA is valid!

drewfish commented 9 years ago

+1

caridy commented 9 years ago

+1