search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

improve documentation #61

Closed SerkanSipahi closed 9 years ago

SerkanSipahi commented 9 years ago

explain where template comes

yahoocla commented 9 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

SerkanSipahi commented 9 years ago

CLA, done !

ericf commented 9 years ago

@SerkanSipahi thanks for this! Although we plan to remove the docs from the README to keep it developer related and link over to the real docs for this package on the website: http://formatjs.io/handlebars/

SerkanSipahi commented 9 years ago

@ericf i know the site. It is possible to edit it -> http://formatjs.io/handlebars/ ?

ericf commented 9 years ago

Yup, the site's code is here: https://github.com/yahoo/formatjs-site

Here's where the docs show the code that "renders" the example templates: https://github.com/yahoo/formatjs-site/blob/master/shared/components/handlebars-example.jsx#L14-18

SerkanSipahi commented 9 years ago

@ericf can you merge the pull request. I will complete the "improvement of document" on https://github.com/yahoo/formatjs-site

SerkanSipahi commented 9 years ago

@ericf ?

ericf commented 9 years ago

@SerkanSipahi like I said, the plan is to gut this README, similar to what we've done here: https://github.com/yahoo/react-intl