search

formbio / laava

LAAVA: Long-read AAV Analysis
MIT License
6 stars 1 forks source link

Form Bio workflow MVP #9

Closed etal closed 5 months ago

etal commented 6 months ago

Ready for review -- successful Form Bio workflow runs on PacBio example scAAV and ssAAV datasets are in the AAV QC workshop project on the platform.

Additional features and improvements beyond this MVP will be in separate pull requests.

etal commented 5 months ago

@etal my only concern is that there is no param to set container version and I don't know if we want the workflow to always use "latest" -- in our currently workflow we use version to indicate container version -- ie version="latest" in your case; but it might make sense to have a laava specific param ie --laavadockerversion -- that is tied to your release versions.

@bcantarel Good point, I've pinned the container to a specific digest in each Nextflow process. After this PR lands I'll tag the git repo with a version, and use the same tag with the docker image. There will be more refactoring later, but the repo tag, docker image tag, and LAAVA workflow versions will stay the same.

FYI @alphabdiallo