search

formbricks / formbricks

Open Source Survey Platform
https://formbricks.com
Other
6.73k stars 1.16k forks source link

[TWEAK] Rewrite Cal.com embed to use Atom #2542

Open jobenjada opened 5 months ago

jobenjada commented 5 months ago

Problem: Currently, the Cal.com embed isn't properly styled

Here you see the issue: Image

Solution: Use the new Cal.com Atoms to embed the Form directly without iFrame and be able to style it with the Formbricks CSS variables https://cal.com/docs/platform#3.-booker-atom

Tasks

  1. Replace the existing embed in the surveys package with the Booking Atom
  2. Pass the correct Formbricks styles CSS variables to the Atom to style it appropriately

Context

The relevant files are these ones:

CalEmbed Question: https://github.com/formbricks/formbricks/blob/main/packages/surveys/src/components/general/CalEmbed.tsx

Styling We use CSS variables to pass the different setting users can use in the Styling tab to the different elements of the survey. The CSS variables can be found in https://github.com/formbricks/formbricks/blob/main/packages/surveys/src/styles/global.css

Consult with GPT what's the best way to remove it. You might get to open a PR at the Cal.com repo to get it sorted 🤓

Feel free to ping me in Discord if you get stuck (@jobenjada)

PeerRich commented 5 months ago

yeah atoms would make a ton of sense here

nik132-eng commented 5 months ago

/assign

oss-gg[bot] commented 5 months ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 5 months ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 5 months ago

This issue is already assigned to another person. Please find more issues here.

varunguleriaCodes commented 4 months ago

/assign

oss-gg[bot] commented 4 months ago

Issue unassigned.

rushatgabhane commented 4 months ago

/assign

oss-gg[bot] commented 4 months ago

Assigned to @rushatgabhane! Excited to have you ship this 🕹️

rushatgabhane commented 4 months ago

previous assignees didn't submit a PR, so im assigning myself

jobenjada commented 3 months ago

@rushatgabhane how is it going? :)

rushatgabhane commented 3 months ago

hey sorry, i was caught up with work. i'll work on this today / unassign if i cannot

devsargam commented 3 months ago

/assign

oss-gg[bot] commented 3 months ago

With your current level, you are not yet able to work on this issue. Please have a look on oss.gg to see which levels can work on which issues 🤓

devsargam commented 3 months ago

Hey @jobenjada, is there any way I can work on this issue?

DeepaPrasanna commented 2 months ago

/assign

oss-gg[bot] commented 2 months ago

With your current level, you are not yet able to work on this issue. Please have a look on oss.gg to see which levels can work on which issues 🤓

jobenjada commented 1 month ago

@DeepaPrasanna @rushatgabhane @devsargam

The issue is up for grabs and the /assign for self-assignment should work now 🤓

DeepaPrasanna commented 6 days ago

/assign

oss-gg[bot] commented 6 days ago

Assigned to @DeepaPrasanna! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

jobenjada commented 5 days ago

This isn't an easy one, feel free to ping us on Discord if you have questions

geraldmaboshe commented 5 days ago

/assign

oss-gg[bot] commented 5 days ago

This issue is already assigned to another person. Please find more issues here.

DeepaPrasanna commented 4 days ago

This isn't an easy one, feel free to ping us on Discord if you have questions

Yes! I am facing issue. I am linking the discord help question here for reference: https://discord.com/channels/979077669410979880/1290911584335429689