formbricks / formbricks

Open Source Survey Platform
https://formbricks.com
Other
5.9k stars 953 forks source link

feat: Hidden fields and metadata for integrations #2752

Closed Dhruwang closed 1 week ago

Dhruwang commented 2 weeks ago

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/130

Adds hidden fields and metadata to following integrations

Screenshot 2024-06-11 at 2 57 27 PM Screenshot 2024-06-11 at 2 57 42 PM Screenshot 2024-06-11 at 2 58 05 PM Screenshot 2024-06-11 at 2 57 54 PM

How should this be tested?

Open integration modal, check Include Hidden Fields and Includes Metadata

Checklist

Required

Appreciated

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **formbricks-cloud** | ⬜️ Ignored ([Inspect](https://vercel.com/formbricks/formbricks-cloud/G6Ryy3Cg9iWXvNaCwUQyQk1RRtpL)) | [Visit Preview](https://formbricks-cloud-git-hidden-fields-and-metada-69295d-formbricks.vercel.app) | | Jun 13, 2024 9:12am | | **formbricks-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/formbricks/formbricks-docs/FuiTxh4h3NF8ieb2hcPdyxJoq3KB)) | [Visit Preview](https://formbricks-docs-git-hidden-fields-and-metadat-36080b-formbricks.vercel.app) | | Jun 13, 2024 9:12am |
github-actions[bot] commented 2 weeks ago

Thank you for following the naming conventions for pull request titles! 🙏

jobenjada commented 2 weeks ago

Hey @Dhruwang

thanks for your good work, this has been requested several times now :)

Thanks for the screenshots in the PR description 🙌

Here are the open To Dos:

  1. Please also open a PR in the landing page repo with an update to the docs pages, where needed
  2. I ran into this error which seems unrelated but maybe you have an idea:
image

It happened when I clickend on "Create custom action" as a survey trigger for an app survey.

🚨 Note: I did not set up all the integrations locally to test it through. The webhook contains the additional information and I suppose testing it on prod once it's live is the more efficient way.

Thanks! :)

gupta-piyush19 commented 1 week ago

@Dhruwang thanks for the fixes. LGTM 🚀