fix: progress bar issue

Dhruwang commented 1 week ago

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/238

Progress bar getting stuck at end

https://github.com/formbricks/formbricks/assets/67850763/e42199a8-b0d0-4335-bc71-5c3e82facc21

How should this be tested?

Test survey with a lot of questions and logic

Checklist

Required

[x] Filled out the "How to test" section in this PR
[x] Read How we Code at Formbricks
[x] Self-reviewed my own code
[x] Commented on my code in hard-to-understand bits
[x] Ran pnpm build
[x] Checked for warnings, there are none
[x] Removed all console.logs
[x] Merged the latest changes from main onto my branch with git pull origin main
[x] My changes don't cause any responsiveness issues
[x] First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

[x] If a UI change was made: Added a screen recording or screenshots to this PR
[x] Updated the Formbricks Docs if changes were necessary

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

github-actions[bot] commented 1 week ago

Thank you for following the naming conventions for pull request titles! 🙏

jobenjada commented 1 week ago

hey dhru! Definitely solves the problem :)

However, I have the case that if a question has a logic jump, if the user goes the longer route, for the next question the progress bar doesn't move:

https://github.com/formbricks/formbricks/assets/72809645/eebf3310-36e8-40ca-b7f9-fc2ad49dd238

It's not super bad and if it keeps the logic a lot simpler we can leave it at that. But initially, we decided that the bar should always move a little bit so that users have to impression that they keep making progress :)

Thanks!

formbricks / formbricks