formers / former

A powerful form builder, for Laravel and other frameworks (stand-alone too)
https://formers.github.io/former/
1.34k stars 204 forks source link

Fix Bootstrap 4 validation messages not being colored red #579

Closed stayallive closed 5 years ago

stayallive commented 5 years ago

I have not touched the other frameworks because time and not having all the knowledge. However this opens up the possibility to differentiate between validation error help messages and just plain help messages (like a user would post).

Also fixed Bootstrap 4 needing is-invalid instead of has-error and add that class to the actual input element, on the group it has no effect.

Also some fixes to the actual help blocks and matched them to how they're displayed in the documentation, relevant sections:

Result:

image

yannrobin commented 5 years ago

Hello,

Any Ideas of when this will be pushed as an update ?

Thanks

claar commented 5 years ago

@yannrobin Thanks for the nudge -- merged and released in 4.1.11.

yannrobin commented 5 years ago

Thanks for that, It will be helpful

stayallive commented 5 years ago

Thanks! :)

claar commented 5 years ago

Thanks for contributing, @stayallive !