search

formers / former

A powerful form builder, for Laravel and other frameworks (stand-alone too)
https://formers.github.io/former/
1.34k stars 205 forks source link

On pages without an open tag, this would currently fail #589

Closed CedNet closed 5 years ago

CedNet commented 5 years ago

With this change it now works as it does with TwitterBoostrap3 where there is no optional class depending on type of form in the open tag.

claar commented 5 years ago

Hi @CedNet,

Thanks so much for the issue report and PR. The Former::open() call isn't currently optional. There are multiple places in the codebase that depend on open() having been called before using other classes such as Former::checkbox('foo').

Changing this assumption would be a welcome PR, but I imagine it would be a large effort. This package is currently only offering maintenance support at the moment, not new development, so such a change would have to come from others.

Thank you!