Allow installation on Laravel 10

formers / former

A powerful form builder, for Laravel and other frameworks (stand-alone too)

https://formers.github.io/former/

1.34k stars 204 forks source link

Allow installation on Laravel 10 #612

Closed stayallive closed 1 year ago

stayallive commented 1 year ago

[x] Allow installing on Laravel 10 (not tested further than the test suite, so might have some rough edges)
[x] Cleanup all PHP 8+ deprecations caught by our own testsuite
[x] Add tests on PHP 8.2 to GitHub actions
[x] ~~Requires two upstream PRs merged and released to solve all deprecation messages caught by the test suite (but not a blocker for a release)~~
- [x] ~~Anahkiasen/html-object#35~~
- [x] ~~Anahkiasen/html-object#36~~
[x] Replace anahkiasen/html-object with fork kylekatarnls/html-object, this one is drop in replacement with PHP 8(.2) fixes integrated

claar commented 1 year ago

@stayallive Perhaps we should create a minimal formers/html-object fork since @Anahkiasen seems to be about as active as I am these days on these repos. This feels like one of those PRs that could end up unmergable for quite some time due to the dependencies. Your thoughts?

stayallive commented 1 year ago

A fork was made with the proper fixes, what about switching to that one?

https://github.com/Anahkiasen/html-object/pull/35#issuecomment-1445331429

We could also fork ourselfs ofcourse if you'd rather see that?

claar commented 1 year ago

@stayallive Whatever you prefer - you're the one moving us forward. Thank you!

eronisko commented 1 year ago

Hi @stayallive, thanks for taking this on! Is there any way I can help merge this in?

stayallive commented 1 year ago

Hey @eronisko, I was talking with a fork maintainer for "replacing" html-object, however they never got back to me and I kinda forgot to check, but seems like I'm unblocked now. So I will update the PR and probably merge it first thing next week (to not ruin anyones weekend just in case).