formilyjs / antd

Formily Ant Design Adaptor
MIT License
51 stars 45 forks source link

修复FormItem wrapper 子元素宽度超出时 页面出现滚动条的问题 #4

Closed Nokecy closed 1 year ago

Nokecy commented 1 year ago

Before submitting a pull request, please make sure the following is done...

Please do not delete the above content


What have you changed?

netlify[bot] commented 1 year ago

Deploy Preview for formily-antd5 ready!

Name Link
Latest commit 0b1618db79b9ad2a7079a4eb8f17f629cf9858fb
Latest deploy log https://app.netlify.com/sites/formily-antd5/deploys/63f5f9e810d2e300072b8a80
Deploy Preview https://deploy-preview-4--formily-antd5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@af5c5ab). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4 +/- ## ========================================== Coverage ? 100.00% ========================================== Files ? 1 Lines ? 39 Branches ? 18 ========================================== Hits ? 39 Misses ? 0 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=formilyjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=formilyjs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Nokecy commented 1 year ago

@yiyunwan 大佬有空看下这个PR有没有问题

yiyunwan commented 1 year ago

大部分场景超出是需要滚动条的,如果你确定不需要可以传进wrapperStyle修正

yiyunwan commented 1 year ago

还有就是,你提的代码不规范,你应该没有本地npm i

Nokecy commented 1 year ago

wrapperStyle 好像不是在wrapper最上面的元素上 https://github.com/Nokecy/antd/blob/0b1618db79b9ad2a7079a4eb8f17f629cf9858fb/packages/components/src/form-item/index.tsx#L231 看代码直接放在了子元素上了,这样设置了宽度一样不对。。 @yiyunwan