formio / formio.js

JavaScript powered Forms with JSON Form Builder
https://formio.github.io/formio.js
MIT License
1.89k stars 1.06k forks source link

FIO-7808: fixed an issue where conditional editGrid loses the value after submission #5511

Closed TanyaGashtold closed 8 months ago

TanyaGashtold commented 8 months ago

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7808

Description

What changed?

When the validator is run on the server side, the server option is passed for the form and the setValue is called. When the server option is passed, the clearOnHide method unsets the components values once the conditions check defines that the component is not conditionally visible. The setValue method of editGrid can potentially trigger the conditions check 4 times and it can appear that the values are unset for the editGrid before the other form values are set and the conditions check on the form level is triggered . This PR allows only the conditions check that comes from the form level for the hidden editGrid with server option.

Why have you chosen this solution?

Since this kind of issue is reported for editGrid component only and related to its server behavior, i was trying to make my changes closely specific to editGrid and server option, not to break other components and use cases.

How has this PR been tested?

Formiojs and formio-server tests with those changes are passed for me locally. I have added automated tests for all use cases where I was able to see the similar issue.

Checklist: