Bugfix: WizardBuilder removes page when saving other component with duplicate API key - Githubissues

formio / formio.js

JavaScript powered Forms with JSON Form Builder

https://formio.github.io/formio.js

MIT License

1.83k stars 1.04k forks source link

Bugfix: WizardBuilder removes page when saving other component with duplicate API key #5568

Open akgagnat opened 2 months ago

akgagnat commented 2 months ago

Link to Jira Ticket

N/A

Description

How to reproduce the bug:

Go to formio sandbox
Change form display to 'wizard'
Insert a new component (e.g. Text Field) in page, provide same API key as the page and save
Observe error 'API key is not unique'
Edit component, provide a unique API key and save
The page has now been removed (actually replaced by the component that was changed)

What is changed in this PR:

The lookup in WizardBuilder's saveComponent event handler is done based on id instead of key.

Dependencies

N/A

How has this PR been tested?

I added unit tests.

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] My changes include tests that prove my fix is effective (or that my feature works as intended)
[x] New and existing unit/integration tests pass locally with my changes
[x] Any dependent changes have corresponding PRs that are listed above