formio / formio.js

JavaScript powered Forms with JSON Form Builder
https://formio.github.io/formio.js
MIT License
1.83k stars 1.04k forks source link

FIO-8389: Fix EditGrid with Empty/Is Not Empty conditional logic in there #5612

Closed mikekotikov closed 4 weeks ago

mikekotikov commented 1 month ago

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8389

Description

What changed?

Previously, formio.js would fail to call 'isEmpty' method if it doesn't exist. This PR adds a check to make sure it exists, before calling.

Dependencies

@formio/core:98

How has this PR been tested?

I added automated tests to cover conditionals cases in Edit Grid with Text field and Checkbox components, corresponding to the scenario where this bug was uncovered.

Checklist:

mikekotikov commented 4 weeks ago

Closing, since another PR is made to fix this