search

formio / ngFormio

JSON powered form rendering library for AngularJS + Form.io.
http://formio.github.io/ngFormio/
MIT License
99 stars 102 forks source link

Fixes #641 #642

Closed kamsi closed 5 years ago

kamsi commented 5 years ago

I used lts/dubnium node when executing npm run build

travist commented 5 years ago

Not sure if this is right...I am curious why the documentation here shows including jQuery the way we do it.

https://webpack.js.org/configuration/externals/#externals

kamsi commented 5 years ago

@travist good point. I think it is because they assume that the jquery will be loaded from external source, I guess in that case you would have jQuery object on root variable (not sure though). I mean, clearly it creates invalid configuration when you do use jquery as as node module through webpack (as then it falls into first if and is flat wrong). In any case I don't suspect there is anything you can really do about it as someone is bound to be unhappy: either people who use jquery from node like I do, or someone else (possibly majority). So, I guess you are a victim here too, you followed the webpack's instructions. OK closing this one... maybe I should open something for webpack itself.