formio / vue

Javascript Powered forms and JSON form builder for Vue.js
MIT License
119 stars 65 forks source link

set esModuleInterop to true in tsconfig #33

Closed cymen closed 4 years ago

cymen commented 4 years ago

This resolves the bug seen in issue #29. I'm trying to use vue-formio in a project that is not using typescript and that error was coming up. With this change to tsconfig, I'm able to use vue-formio.

tnorthcutt commented 4 years ago

Is there anything blocking this from getting merged? I really don't love the idea of forking this or modifying it just to get it to work in our project.

From reading the associated issue, I suspect merging this would save many hours of frustration when added up across anyone who runs into this in the future...

Sefriol commented 4 years ago

This repo is just in very low maintenance. Most likely just not in very high priority.

tnorthcutt commented 4 years ago

@cymen Are you just using your fork as a dependency for now instead of this repo?

cymen commented 4 years ago

@tnorthcutt I ended up using the vanilla JS formio instead of the Vue one. Partly due to this issue. I'm honestly a bit surprised at the lack of consistency between the different formio offerings (vanilla JS vs Vue vs React vs Angular).

Sefriol commented 4 years ago

We are running quite a big project using vue-formio, but with with javascript based stack instead of typescript. So far no bigger problems and most of the problems we have encountered are more related to formio.js than this library itself.

I guess it depeds on your use case.

tnorthcutt commented 4 years ago

@cymen thanks for your response; I suspect that's what I'll end up doing, and just create a small wrapper component to implement the vanilla library.

@Sefriol Are you using a fork as a dependency, or were you somehow able to overcome this issue in another way?

Sefriol commented 4 years ago

This issue does not appear if you import this package into standard vue-javascript stack.

EDIT: But in general, I think combining all open pull requests and using that is probably to way a go forward if you are using typescript.

tnorthcutt commented 4 years ago

@Sefriol I'm still seeing the issue, trying to import this package into what I think is a standard vue app 😕

@randallknutson Any chance you'll be merging this?