search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

fix(): added functionality for issue number 531 #534

Closed MCKRUZ closed 8 years ago

MCKRUZ commented 8 years ago

swaped out obj[prop] functionality for for deep level objects

codecov-io commented 8 years ago

Current coverage is 95.93%

Merging #534 into master will increase coverage by +0.05% as of d64462e

@@            master    #534   diff @@
======================================
  Files           16      16       
  Stmts         1094    1107    +13
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1049    1062    +13
  Partial          0       0       
  Missed          45      45

Review entire Coverage Diff as of d64462e

Uncovered Suggestions

  1. +0.36% via ...alidationMessages.js#25...28
  2. +0.27% via src/test.utils.js#38...40
  3. +0.27% via ...s/formlyUsability.js#18...20
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

MCKRUZ commented 8 years ago

Ok I think I got it.

kentcdodds commented 8 years ago

:-( your other PR had tests :-( also, your commit message needs to have a scope: fix(formly-field)

MCKRUZ commented 8 years ago

Bah!!! I forgot to include the tests! Le sigh….ok I’ll try again later.

From: "Kent C. Dodds" notifications@github.com Reply-To: formly-js/angular-formly reply@reply.github.com Date: Monday, November 2, 2015 at 3:17 PM To: formly-js/angular-formly angular-formly@noreply.github.com Cc: Matt Kruczek kruz79@gmail.com Subject: Re: [angular-formly] fix(): added functionality for issue number 531 (#534)

:-( your other PR had tests :-( also, your commit message needs to have a scope: fix(formly-field)

— Reply to this email directly or view it on GitHub.

kentcdodds commented 8 years ago

ping?