search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

showError variable not correct for control types with multiple inputs #548

Closed interrobrian closed 8 years ago

interrobrian commented 8 years ago

If a formly control type contains multiple input elements, then the showError variable always comes into the template as false.

kentcdodds commented 8 years ago

Could you produce an example with issue.angular-formly.com. Thanks!

kentcdodds commented 8 years ago

Actually, this is a duplicate: https://github.com/formly-js/angular-formly/issues/510

interrobrian commented 8 years ago

Okay, I'll change my PR to reference the other issue

kentcdodds commented 8 years ago

Please check out the conversation over there. You'll need to adjust your implementation a bit.

interrobrian commented 8 years ago

Ah, looks like that other implementation is better anyway, so I'll hold off. Sorry for jumping the gun!

Date: Wed, 11 Nov 2015 11:05:52 -0800 From: notifications@github.com To: angular-formly@noreply.github.com CC: brianspencer@outlook.com Subject: Re: [angular-formly] showError variable not correct for control types with multiple inputs (#548)

Please check out the conversation over there. You'll need to adjust your implementation a bit.

— Reply to this email directly or view it on GitHub.

kentcdodds commented 8 years ago

Nope, you're good. I think that @chrisheninger could use some help with that actually if you want to collaborate on #510 that'd be cool.