formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

fix(formly-field): Breaking change in @7.3.2? Key value? #566 #573

Closed MCKRUZ closed 8 years ago

MCKRUZ commented 8 years ago

Fixed this to handle GUIDS

codecov-io commented 8 years ago

Current coverage is 95.87%

Merging #573 into master will decrease coverage by -0.06% as of ccb8f27

@@            master    #573   diff @@
======================================
  Files           16      16       
  Stmts         1108    1114     +6
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1063    1068     +5
  Partial          0       0       
- Missed          45      46     +1

Review entire Coverage Diff as of ccb8f27


Uncovered Suggestions

  1. +0.35% via ...alidationMessages.js#25...28
  2. +0.27% via ...s/formlyUsability.js#18...20
  3. +0.27% via src/test.utils.js#38...40
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

Fantastic. Thanks for working on this! Merging.

As a friendly reminder, the issue number should be at the bottom of the commit per our commit convention guidelines. So this one should be:

fix(formly-field): Add better detection of nested keys

Closes #566
MCKRUZ commented 8 years ago

Sure no problem, will be in the future

kentcdodds commented 8 years ago

Thanks again!