search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

chore(webpack): add uglify-loader #582

Closed benoror closed 8 years ago

benoror commented 8 years ago

for production

Fixes #581

codecov-io commented 8 years ago

Current coverage is 95.88%

Merging #582 into master will not affect coverage as of 8a51064

@@            master    #582   diff @@
======================================
  Files           16      16       
  Stmts         1117    1117       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           1071    1071       
  Partial          0       0       
  Missed          46      46

Review entire Coverage Diff as of 8a51064

Uncovered Suggestions

  1. +0.35% via ...alidationMessages.js#25...28
  2. +0.27% via src/test.utils.js#38...40
  3. +0.27% via ...s/formlyUsability.js#18...20
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

Hi @benoror, the uglify loader actually has some problems with it. We should actually remove it from the devDependencies. We should instead use the Uglify Plugin

benoror commented 8 years ago

Ok, gonna fix it now

kentcdodds commented 8 years ago

Thanks @benoror! :+1: