search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

Support for meteor #591

Closed kamilkisiela closed 8 years ago

kamilkisiela commented 8 years ago

@kentcdodds All you have to do is to add a webhook https://autopublish.meteor.com/publish with Release event

codecov-io commented 8 years ago

Current coverage is 95.88%

Merging #591 into master will not affect coverage as of 33e97fc

@@            master    #591   diff @@
======================================
  Files           16      16       
  Stmts         1117    1117       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           1071    1071       
  Partial          0       0       
  Missed          46      46

Review entire Coverage Diff as of 33e97fc

Uncovered Suggestions

  1. +0.35% via ...alidationMessages.js#25...28
  2. +0.27% via src/test.utils.js#38...40
  3. +0.27% via ...s/formlyUsability.js#18...20
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I'm not sure what the webhook is for. This gulp task will run as part of our automated releases on travis. What's the purpose of the webhook?

kamilkisiela commented 8 years ago

We cannot use some sort of command like "npm publish" on meteor so webhook is to trigger the publish process provided by autopublish.meteor.com.

This is the only automatic way.

@kentcdodds Is it a problem?

kentcdodds commented 8 years ago

Merged and webhook created. Let me know if you need anything else!