search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.22k stars 405 forks source link

Update invalid cdn on angular-formly example page #609

Closed sandip-wane closed 8 years ago

sandip-wane commented 8 years ago

Hi, it seems some of the example on http://angular-formly.com/#/ are not working due to wrong cdn address, making preview of example non-usable. I found 'ui-bootstrap tabs' example working when changed cdn of ui-bootstrap. There are also other few example which have similar/other problem. Please update these update these examples.

kentcdodds commented 8 years ago

The examples seem to be working fine for me... Could you check them again?

kamilkisiela commented 8 years ago

As I wrote in formly-js/angular-formly-website#93

angular-ui-bootstrap v1.0.0 has a breaking change.

kentcdodds commented 8 years ago

Thanks @kamilkisiela! :D

kamilkisiela commented 8 years ago

@kentcdodds I fixed that in few others examples.

https://github.com/formly-js/angular-formly-website/compare/ebd26ff...c1c2577

So if any other example uses angular-ui-bootstrap it should be fixed immediately

benoror commented 8 years ago

@kamilkisiela super! :+1:

sandip-wane commented 8 years ago

Thanks for the fix and sorry for posting issue in wrong place :disappointed: