search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.23k stars 405 forks source link

give proper error msg when no type on field configuration object #628

Closed sukrosono closed 8 years ago

sukrosono commented 8 years ago

will listen if any feedback :smile:

codecov-io commented 8 years ago

Current coverage is 96.00%

Merging #628 into master will not affect coverage as of 9d1bbbc

@@            master   #628   diff @@
=====================================
  Files           16     16       
  Stmts         1150   1152     +2
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit           1104   1106     +2
  Partial          0      0       
  Missed          46     46

Review entire Coverage Diff as of 9d1bbbc

Uncovered Suggestions

  1. +0.35% via ...alidationMessages.js#25...28
  2. +0.26% via ...s/formlyUsability.js#18...20
  3. +0.26% via src/test.utils.js#38...40
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I'm sorry, but as you can see in the comments, I said I don't want to add another error message because it simply doesn't make sense to have two error messages for the same thing. The very next line is the same error. If you want to update that message, we can talk about that, but adding another message is something I simply won't do.

sukrosono commented 8 years ago

@kentcdodds as i remember it not give 2 errors dude, but yes it's complicates the codebase. nothing to sorry, i just wonder someone lead to same things which i did. Since i know you starting busy after i watch angular air ep 0.