formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.23k stars 405 forks source link

fix(formly-form): validateOnModelChange now copes when field.formControl is an array #523 #641

Closed dickp closed 8 years ago

dickp commented 8 years ago

What

Fix for issue #523

Why

Bug fix

How

If field.formControl is an array, then call $validate method of each element

Checklist:

codecov-io commented 8 years ago

Current coverage is 96.01%

Merging #641 into master will increase coverage by +0.01% as of 505fc8f

@@            master    #641   diff @@
======================================
  Files           16      16       
  Stmts         1150    1155     +5
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1104    1109     +5
  Partial          0       0       
  Missed          46      46       

Review entire Coverage Diff as of 505fc8f


Uncovered Suggestions

  1. +0.35% via ...alidationMessages.js#25...28
  2. +0.26% via ...s/formlyUsability.js#18...20
  3. +0.26% via src/test.utils.js#38...40
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

Looks good to me. But I would like someone else to merge this: @formly-js/angular-formly-collaborators

kentcdodds commented 8 years ago

Anyone in @formly-js/angular-formly-collaborators-read who feels confident they can have commit access, I'll add you to @formly-js/angular-formly-collaborators :-)

immortalcy commented 8 years ago

@kentcdodds @ckniffen Is there a way to check if bug #594 still happens? It was a similar bug that happened with repeat sections.. If a release was out we could check it on this bin.

kentcdodds commented 8 years ago

Unfortunately it looks like it's not fixed

kentcdodds commented 8 years ago

Actually, it looks like this wasn't auto-released for some reason :-( Filing an issue.

immortalcy commented 8 years ago

That's the reason I asked if there is a way to check the updates on that version.. sorry for not being clear on my previous message.

kentcdodds commented 8 years ago

Yeah, it hasn't yet been released because there's a problem. So no, there's not really a way... Feel free to help out here: #643