search

formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.23k stars 405 forks source link

Fix auto-release #643

Closed kentcdodds closed 8 years ago

kentcdodds commented 8 years ago

If someone wants to look at why the semantic-release part of this build failed, that would be great. We wont get new versions of angular-formly released until this is resolved.

BarryThePenguin commented 8 years ago

The problematic commit 28c648dc83cb75ded78e5d984a81cfd19c544e1c

Now just trying to figure out what went wrong/how to restore it...

BarryThePenguin commented 8 years ago

@kamilkisiela do you still have reference to 28c648dc83cb75ded78e5d984a81cfd19c544e1c, it looks like the branch referencing the commit was deleted, or was overwritten by a force push. Are you able to restore it?

Instructions: https://help.github.com/articles/commit-exists-on-github-but-not-in-my-local-clone/

BarryThePenguin commented 8 years ago

Either that or @kentcdodds will need to publish manually...

kentcdodds commented 8 years ago

If I publish manually, will things go back to normal?

BarryThePenguin commented 8 years ago

Sounds like it. The latest release on npm (7.5.0) has a gitHead of 28c648dc83cb75ded78e5d984a81cfd19c544e1c. That no longer exists in git history for some reason. So semantic-release falls over when it tries to compare all commits since that specific commit

kentcdodds commented 8 years ago

Alrighty, released 7.5.1. I'll merge #639 after I verify this is fixed with the new release.

kamilkisiela commented 8 years ago

I'm ofline for few days. Is it working now? Do you need any help?

About commit, I don't have that commit in my local branch.

vltr commented 8 years ago

Hi! Is this related to the fact that the 8.0.0 of the bower package doesn't comes with the generated dist files while npm package does?

kentcdodds commented 8 years ago

Looks like bower's broken as well... I'm actually tempted to stop officially supporting bower and direct people to the solution in #589 with npmcdn.com

vltr commented 8 years ago

Wow. Good article referenced in #589. I think I might migrate all my dependencies to npm as well :smile:

DrDanRyan commented 8 years ago

jspm is broken as well. JSPM registry points to the github project but the lack of a dist folder (main is still dist/formly.js) results in jspm unable to load it.

If you tell jspm to install from npm, then it tries to use npm:angular as a dependency which causes a console error of angular tried to load more than once since the main jspm angular install defaults to github:angular/bower-angular.

vltr commented 8 years ago

[imho] What a mess ...

kentcdodds commented 8 years ago

[imho] What a mess ...

Agreed... :-(

@DrDanRyan, do you have any ideas of how to fix this issue? I'm not sure what's going on with the release, but if you'd like to look into it, please feel free: https://travis-ci.org/formly-js/angular-formly/builds/111880609

kentcdodds commented 8 years ago

Good thing you can continue using version 7 and it works just as well as it always has :-)

vltr commented 8 years ago

@kentcdodds almost forgot! Made this example some days ago: http://jsbin.com/fepilo/7 :smiley:

And I'm already using version 8 from npm :wink:

kentcdodds commented 8 years ago

Ah! Neat! Want to add it to the examples site? https://github.com/formly-js/angular-formly-website/blob/master/CONTRIBUTING.md#creating-an-example

vltr commented 8 years ago

@kentcdodds yeah, I'll love to. I also made an integration with Leaflet, but I'll create an example later (time!) :smiley:

vltr commented 8 years ago

PR waiting :wink:

kentcdodds commented 8 years ago

Hmmm... I'm not seeing it here...

vltr commented 8 years ago

Damn, I always forget the last step!

JordanBelford commented 8 years ago

jspm install angular-formly installs 7.5.2, which is broken because there is no dist directory.

For now I am just installing 7.3.9 with jspm install angular-formly=github:formly-js/angular-formly@7.3.9

Installing from npm grabs 8.0.0, but I there is no 8.0.0 release or tag on github, as far as I can tell. What's that about?

BarryThePenguin commented 8 years ago

Took a bit of messing around. But I think this is fixed now. Some release notes have gone missing. Anyway to build those manually? Anyone want to give it a go?

BarryThePenguin commented 8 years ago

Looks like we got this sorted

kentcdodds commented 8 years ago

Thank you for the help @BarryThePenguin!