formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.23k stars 405 forks source link

Custom Validations select is double the label. #652

Closed berdemer closed 8 years ago

berdemer commented 8 years ago

jsBin When used in conjunction Custom Validators and select is double the label. best regards

kentcdodds commented 8 years ago

A wrapper without defined name or type will be set as the default template. This could probably be made more clear in the docs

You can have a default (used by all templates), named template wrappers, and typed template wrappers (used by fields with the specified type)

If you give the first wrapper a name, or types, you'll see this behavior is corrected: https://jsbin.com/tafiwa/edit?html,js,output

In the future, please ask questions in the chat: http://chat.angular-formly.com thanks!

kentcdodds commented 8 years ago

Just realized that perhaps you didn't ask this in the chat because you legitimately thought it was a bug. Thanks for the reproducible example! That made it much easier to help you :sparkles: