formly-js / angular-formly

JavaScript powered forms for AngularJS
http://docs.angular-formly.com
MIT License
2.23k stars 405 forks source link

8.0 + Model Changes not updating form #656

Closed TheMcMurder closed 8 years ago

TheMcMurder commented 8 years ago

Code is the same in these two examples:

8.0.3 : http://jsbin.com/holiro/2/edit?html,css,js,output 7.5.1 : http://jsbin.com/jivojo/3/edit?html,css,js,output

Notice that when the model changes in 7.5.1 the form updates but when the model changes in 8.0.3 the form no longer changes

JacoBezuidenhout commented 8 years ago

+1 same problem here

BarryThePenguin commented 8 years ago

@kwypchlo, are you able to look into this? I'm assuming it's related to the breaking change that was introduced in #639. It may be that it just needs to be documented a little more.

JordanBelford commented 8 years ago

Are there any other breaking changes with 8.0?

melnac commented 8 years ago

I have the same problem. What can i do to resolve or workaround the problem ? I am using v8.0.3 and all my application is now broken. Resolution is very urgent. Thanks in advance.

BarryThePenguin commented 8 years ago

@melnac until this get's sorted you'll have to use a version before 8.0.0

melnac commented 8 years ago

thanks for reply. Where i can get a version before 8.0.0. I use formly via cdn...

BarryThePenguin commented 8 years ago

According to @TheMcMurder jsbin above, it's available at https://npmcdn.com/angular-formly@7.5.2

melnac commented 8 years ago

many thanks, i will try

kwypchlo commented 8 years ago

I prepared pull request #657 that fixes that issue, sorry for the inconvenience. @BarryThePenguin could you take a look?

abodacs commented 8 years ago

+1 same problem here

BarryThePenguin commented 8 years ago

This looks good now in 8.0.4. Thanks for your quick assistance @kwypchlo :runner: :dash:

JacoBezuidenhout commented 8 years ago

Ah great!! Thanks guys!!

kentcdodds commented 8 years ago

Thanks @kwypchlo!

giphy