search

formsort / oss

Formsort open source monorepo
19 stars 5 forks source link

React-embed: Allow passing any string for `formsortEnv` #25

Closed lizraeli closed 3 years ago

lizraeli commented 3 years ago

Since users of Formsort can define custom environments, we allow passing any string for the formSortEnv prop in react-embed. This PR updates the prop, and defines a custom type to preserve the auto-complete for the default environments.

Screenshots

Intellisense for default environments:

Screen Shot 2021-08-03 at 4 59 03 PM

Other values are allowed:

Screen Shot 2021-08-03 at 5 03 13 PM
fzembow commented 3 years ago

Cannot access custom environments in react embed library for formsortEnv (types are overconstrained)