search

formsort / oss

Formsort open source monorepo
19 stars 5 forks source link

build: Add Craft for streamlined releases #63

Closed BYK closed 2 years ago

BYK commented 2 years ago

First step of APP-12.

The next step will be creating a GitHub Action to trigger the builds from there.

This now depends on getsentry/craft#379 for proper per-project changelogs.

BYK commented 2 years ago

The changes for release and setup process look good! I think the changes to code should go in a separate PR(s)

Thanks a lot @lizraeli! These changes are due to the setup process and unified linting/type checking. Our code had lots of broken types and builds. I can try to separate them out but then the "release system" PR would only consist of the readme and yarn release script addition. Not sure if that would be really useful.

WDYT?

lizraeli commented 2 years ago

The changes for release and setup process look good! I think the changes to code should go in a separate PR(s)

Thanks a lot @lizraeli! These changes are due to the setup process and unified linting/type checking. Our code had lots of broken types and builds. I can try to separate them out but then the "release system" PR would only consist of the readme and yarn release script addition. Not sure if that would be really useful.

WDYT?

Ah got it, makes sense. Next time could you put this kind of reasoning in the PR description - that would save some of the back-and-forth. Thanks!