formtools / core

The Form Tools Core.
https://formtools.org
205 stars 78 forks source link

PHP 8 support #879

Closed benkeen closed 1 year ago

benkeen commented 1 year ago

Alrighty... time to leap back into this sucker. Look into this this year once generatedata.com 4.1 is released and stable.

koacamper commented 1 year ago

This is great news!

nicktalsma commented 1 year ago

This is awesome news! I literally just got word from my host this morning they are discontinuing support for PHP 7.4.

@benkeen any idea when FormTools might be updated by? And thank you so much for all you've done!!

benkeen commented 1 year ago

Thanks! :)

The challenge is time... I have to do an update for generatedata.com in the next little while to accommodate some changing Google APIs and then I need to spend some time with some iNaturalist.org problems, but I'll be getting into this after that. Shouldn't be too long. I'll post here when I know something more concrete.

Sandy-Spence commented 1 year ago

I had upgraded to PHP8.2 to find that Formtools stopped working so reverted back to PHP7.4. I found this error in my apache2 error log:

each() in /var/www/mydomain/formtools/modules/form_builder/code/FormGenerator.class.php:682

each() is depricated in PHP8.2 and the offending line shows

while (list($col_name, $file_upload_dir) = each($file_field_info))

any suggestions on how I should convert this line.

formtools-each-error.txt the text file is the complete code block.

gummisko commented 1 year ago

Would indeed be so very awesom Ben! Thank you! Gerard

benkeen commented 1 year ago

I should be wrapping up my other work this weekend, so I'll be getting to it after that. :)

Sandy-Spence commented 1 year ago

Wow!

nicktalsma commented 1 year ago

I should be wrapping up my other work this weekend, so I'll be getting to it after that. :)

This literally just made my day hearing this!! Thank you again Ben!

koacamper commented 1 year ago

Are you still accepting donations for this project through the formtools.org site? I'd like to donate to the cause. Thank you again for this wonderful program!

benkeen commented 1 year ago

Thanks, that's kind @koacamper. But I'm afraid that the donation form is a little out of date! Clearly I need to update that too. ;-)

koacamper commented 1 year ago

Let me know when the donations section is updated. Thank you again.

benkeen commented 1 year ago

I've created a separate ticket here to track my progress + take notes. https://github.com/formtools/core/issues/892

Lots to do, but on the bright side I'm not sure there will be too much to do for the actual PHP8 update. I've already gotten the bulk of the core application going, so it'll just be a matter of slogging through every piece of functionality and tweaking it as I go.

benkeen commented 1 year ago

Hey folks, I just released 3.1.0 of the core + a couple modules (Export Manager included). It's running fine for me on PHP 8.2, but do let me know if anyone spots any problems! You can download the new version on the main download page here: https://formtools.org/download/ - but I'll be updating the Upgrade page in coming days to explain why the upgrade functionality is no longer automated.

As I posted on the website I'll be sticking around for bug fixes from here on out. :)

nicktalsma commented 1 year ago

@benkeen you are the man!!! I will be trying the update soon. It looks like I just need to download 3.1.0 from formtools.org, extract the contents of the zip file and upload to my server (overwriting existing files) in order to update? Backing everything up first of course...

benkeen commented 1 year ago

Hey! I updated the upgrade instructions here: https://docs.formtools.org/upgrading/

I do miss the automatic upgrade script, but that's non-functional now. I'll be updating that page today to link to the new instructions.

But yes, that's the gist of it - just uploading the new version + overwriting the old ones. :) You can download the new code version on the download page.

Let me know if you have any trouble!

nicktalsma commented 1 year ago

@benkeen

Upgrade page mentions upgrading to 3.1.5, but isn’t 3.1.0 the latest release that just came out?

https://docs.formtools.org/upgrading/3_1_5/

benkeen commented 1 year ago

Good grief, you just found a very old documentation bug. Apologies! The doc is wrong - it should read 3.0.15, not 3.1.5. I'll update that shortly. [Edit: updated, new page: https://docs.formtools.org/upgrading/3_0_15/ ].

Yup, 3.1.0 is the latest version.

benkeen commented 1 year ago

Sorry folks, but just a heads up that a couple of other issues were spotted around PHP 8 compatibility, so I released 3.1.1 to patch it - plus a few modules. They're all downloadable via the main website.

I posted about it on the main website. I'll continue announcing all updates there in future. https://formtools.org/news/

Thanks!

Sandy-Spence commented 1 year ago

Hello Ben,

I held off updating as we were in the middle of registering delegates for a conference. I performed the update, as per instructions, yesterday. With the exception of one minor issue all appears to have gone well. The issue is that form confirmation e-mails are not delivering html format. I will keep digging to see if I can find out what the cause is.

Thank you for your help.

Sandy.

On Mon, 27 Feb 2023 at 05:16, Ben Keen @.***> wrote:

Sorry folks, but just a heads up that a couple of other issues were spotted around PHP 8 compatibility, so I released 3.1.1 to patch it - plus a few modules. They're all downloadable via the main website.

I posted about it on the main website. I'll continue announcing all updates there in future. https://formtools.org/news/

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/formtools/core/issues/879#issuecomment-1445722066, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXYUUFOBQNO7IVQBA54UIDWZQ2DRANCNFSM6AAAAAAT5O4DA4 . You are receiving this because you commented.Message ID: @.***>

benkeen commented 1 year ago

Good to hear! Yes, let me know about the emails. I've been a little swamped this week but I can take a look a bit later too.

Sandy-Spence commented 1 year ago

Good Morning Ben,

Thank you once again for all that you do.

Regards,

Sandy

On Fri, 10 Mar 2023 at 04:44, Ben Keen @.***> wrote:

Good to hear! Yes, let me know about the emails. I've been a little swamped this week but I can take a look a bit later too.

— Reply to this email directly, view it on GitHub https://github.com/formtools/core/issues/879#issuecomment-1463254470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXYUUG7347TFN5WDL47J4TW3KWS7ANCNFSM6AAAAAAT5O4DA4 . You are receiving this because you commented.Message ID: @.***>