search

formtools / module-form_builder

The Form Builder module.
https://docs.formtools.org/modules/form_builder/
15 stars 21 forks source link

modules\field_type_file delete_submission_file_standalone busted #4

Closed johnbleck3 closed 6 years ago

johnbleck3 commented 6 years ago

Form_Builder forms with upload field on the edit page . . . Delete - are you sure - Yes: if you have a session logged into formtools it works - if you're NOT logged into formtools it does not work. The button does nothing, popup just sits there.

johnbleck3 commented 6 years ago

If I remember correctly, - in hindsight - your intent was to have anyone putting in a form to be logged in one way or another. If that is still the case you can disregard my post, and I would have to come up with a way for the public to fill out these forms without signing in and without the need to delete or figuring out how to mod to accommodate.

benkeen commented 6 years ago

No, this is definitely a bug. Form Builder forms should be publicly available - but there should be sessions already running for the user (independent of the FT sessions that an FT user has when logging in). I'll check this out!

benkeen commented 6 years ago

I've been looking into this further and I'm actually going to pull the code out of the File Upload module and into the Form Builder module where it belongs. Now the Form Builder will call the File Upload module behind the scenes, rather than rely on Form Builder-specific code in the Upload module.

When it's done I'll post again here (hopefully today!), but note it'll require upgrading both the Form Builder + File Upload module.

Thanks!

benkeen commented 6 years ago

Edit! Turns out it didn't require such a drastic change. I've updated the File Upload module + will release a new version of this module now. You'll need to upgrade both, and then (sorry!) to make everything work properly you'll need to rename your published form(s). You can just rename them, then rename them back - the important thing is that the file itself was regenerated to get the latest content.

johnbleck3 commented 6 years ago

Excellent - just tested and works like a charm. Thanks Ben!