search

formulahendry / vscode-terminal

Terminal for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=formulahendry.terminal
46 stars 22 forks source link

output characters display incorrectly if OS is Simplified Chinese version #3

Closed CNMan closed 7 years ago

CNMan commented 8 years ago

2016-07-09_151831

formulahendry commented 8 years ago

@CNMan Which OS are you using?

CNMan commented 8 years ago

windows server 2012 r2 windows server 2016 tp5

formulahendry commented 8 years ago

Hi @CNMan , thanks for your info. I could repro this issue but I would hold on the bug fix or feature development for now because:

  1. VS Code already has basic built-in support for the terminal from v1.2 and add 'run selected text' in v1.3. For now, it just miss one feature of this extension: ability to run the entire text of current active text editor. I have already sent the Pull request and hope it could be merged. If it has been merged, I think this extension could be retired. :smile:
  2. I have another extension: Code Runner. And it is superset of the Terminal extension since it not only supports powershell, bat/cmd, bash/sh but also supports other script language like js, php, python, perl, ruby, go, lua, groovy even F#, C#.

Therefore, I suggest you to use Code Runner. The issue should not exist in this extension. Look forward to your feedback!

CNMan commented 8 years ago

2016-07-23_164500 uninstall Terminal and install Code Runner,but has same issue.

formulahendry commented 8 years ago

Could you let me know your locale setting? image

CNMan commented 8 years ago

2016-07-24_022118

formulahendry commented 8 years ago

Hi @CNMan , I found a workaround for this issue (though make the output be English instead of Chinese). Anyway, it eliminates the messy code. The workaround is to update the config for bat of code-runner.executorMap

{
    "code-runner.executorMap": {
        "bat": "chcp 65001 |"
    }
}

Refer to stackoverflow, #2190 and #2196

formulahendry commented 7 years ago

Hi @CNMan , as another option, you could use Code Runner to run it in built-in terminal:

{
    "code-runner.runInTerminal": true
}