implement brute force solver

foroozandehgroup / esrpoise

Parameter Optimisation by Iterative Spectral Evaluation: an Xepr-compatible ESR package

GNU General Public License v3.0

1 stars 0 forks source link

implement brute force solver #11

Closed yongrenjie closed 3 years ago

yongrenjie commented 3 years ago

accessible via esrpoise.optimize(optimiser="brute")...

just noticed that one is spelt american way and the other is spelt british way... maybe 'algorithm' is a better keyword argument to use!

yongrenjie commented 3 years ago

hmm, interesting, the pull_request tests are failing because merging this into main would cause PEP8 tests to fail on the resulting combination. but the push tests are succeeding because the code I pushed doesn't include the latest changes 😄

JB-V commented 3 years ago

Sorry about this, the setup on the lab computer is pretty rudimentary so I haven't cared for PEP8...

yongrenjie commented 3 years ago

yeah, that's ok, they can always be fixed at a later point... I'm honestly more impressed that you can actually write productive code on that computer!

JB-V commented 3 years ago

it's now connected to internet so maybe I should look into a nicer editor - it might be worth it. Eventually I'll have to look into that python installation which was a bit dodgy...