search

foroozandehgroup / esrpoise

Parameter Optimisation by Iterative Spectral Evaluation: an Xepr-compatible ESR package
GNU General Public License v3.0
1 stars 0 forks source link

add type hints #3

Closed yongrenjie closed 2 years ago

yongrenjie commented 3 years ago

might as well, since xeprapi constrains it to only work with python 3.7+ anyway.

JB-V commented 2 years ago

I have started to add those, what would you recommend I do about ndarray types and xper objects?

yongrenjie commented 2 years ago

You’re very hardworking, I was planning to actually close this issue…

For numpy arrays if you have imported numpy as np, then you can use np.ndarray as the type parameter

On 16 Dec 2021, at 13:03, JB-V @.***> wrote:

 I have started to add those, what would you recommend I do about ndarray types and xper objects?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

JB-V commented 2 years ago

Ok :)