search

forrest-app / forrest

An npm scripts desktop client
MIT License
341 stars 33 forks source link

Forrest cannot be closed from mac menu #28

Closed danez closed 8 years ago

danez commented 8 years ago

When I press close nothing happens. bildschirmfoto 2016-07-25 um 14 10 43

stefanjudis commented 8 years ago

Hmm... works fine here.

Could you start the app with the binary

$ ./.../.../.../Forrest.app/Contents/MacOS/Forrest

and check if some exceptions occur?

danez commented 8 years ago

It works when I start it this way, but not when starting it from the Applications folder by clicking on Forrest.app or on the pinned shortcut in the dock.

Also clicking on the x on the left top of the window, closes the window, but does not close the app. And then there is no way to bring back the window, without forceclosing and reopening.

stefanjudis commented 8 years ago

Hmm... Did the same. Still works. No idea how to approach that. :(

danez commented 8 years ago

Hmm, so i tried downloading the zip and the dmg both do not work for me. Also putting the forrest.app not in /Applications/ but somewhere else does not change anything.

I tried removing ~/Library/Application Support/Forrest which removed all my projects and settings but still not working.

Maybe its the node version? node v4.4.7 npm 3.10.6

Node is installed via nvm and nvm is installed via homebrew. macOS is at the latest version 10.11.6

stefanjudis commented 8 years ago

Okay... Updating OS then today... :D That's the only thing that could matter here.

node and npm shouldn't make any difference as electron (and the app) ships with its own node.

danez commented 8 years ago

For the second problem that after closing the main window I cannot bring back the window this might help: https://github.com/mattermost/desktop/blob/master/src/main.js#L161 Maybe also the event handling for the other events helps, but never worked with electron before.

stefanjudis commented 8 years ago

For the second problem that after closing the main window I cannot bring back the window this might help:

works here as well. Let's see if I can reproduce when I'm on the same os version.

stefanjudis commented 8 years ago

@danez Can you please check if the problem still appears in v1.0.0-beta?

danez commented 8 years ago

I just tried on a different computer. The initial test today was on a Macbook Pro 13' Retina 2015 Now I tested on Macbook Pro 15' 2010, with the same problem. :(

Both have 10.11.6

stefanjudis commented 8 years ago

damn it... yeah, I'll dig the electron bug tracker the next days. but here it's still running perfectly fine.

macosbug

stefanjudis commented 8 years ago

@danez is this still an issue?

danez commented 8 years ago

Yes thanks, delta solves the problem 🎉