search

forrestbao / pyeeg

Python + EEG/MEG = PyEEG
GNU General Public License v3.0
241 stars 85 forks source link

Address #7 #20

Closed bergantine closed 5 years ago

bergantine commented 7 years ago

Forrest,

I wanted to add some unit tests and in so doing broke things apart further, addressing #7 by creating a separate module for each function. I added config files to do CI testing using Travis. It's pulling my branch over (https://travis-ci.org/jbergantine/pyeeg) and should work wiht the main repo at (https://travis-ci.org/forrestbao/pyeeg) if that's something you wanted to setup. If not, I can add .travis.yml to the .gitignore and keep that just for me.

I went on to document how to run the tests and how to lint the file in the readme. I made a few adjustments, mostly to comments to adjust line length, to bring things further inline with PEP8 based on the linting. Any coding changes (as in the code for embedded sequence) were made only after making sure the tests passed before and after the changes.

The changes made to embedded sequence were primarily to address an issue that I encountered in the tests when passing in a list rather than a numpy.ndarray. While I was in there I set verbose variable names as well and updated the doc block.

I tried to sequence my commits in a logical order to follow the breakout from all the methods in the init file into methods in modules.

forrestbao commented 5 years ago

Thank you so much @bergantine . I have manually resolved the conflicts and merged in commits ad90f28478db59e79cac5579a679c47deb3f52bf and 5444dd6e45a5f549a2e03a0552a9ba4f11afd54b.