forrestguice / NaturalHour

A roman timekeeping add-on for Suntimes.
GNU General Public License v3.0
33 stars 2 forks source link

[Bug] - Broken Twilights #30

Closed suntimer24 closed 3 days ago

suntimer24 commented 1 week ago

Describe the bug

Example location: Lattitude: 53,3° N Longitude: 10° E Gregorian year count: 2025

Daylight saving time (dst) 2025 in that region is from 30.03. till 26.10.

Notice, that on 21.06 (begin of summer) there's normaly civil twilight and nautical twilight, but no astronomical twilight, but the app shows only astronomical twilight.

Screenshots 001_-_12 05_-_all_twilight_phases_are_visible 002_-_13 05_-_two_twilight_phases_disappearing 003_-_28 07_-_two_twilight_phases_still_not_visible 004_-_29 07_-_all_twilight_phases_appearing_again

Version Info:

forrestguice commented 6 days ago

Hi. Thanks for taking time to register and report (both here and on the Suntimes tracker). I appreciate it. I'll work through and comment on these issues as I have the time.

I believe this particular bug is actually fixed in v0.2.3, with code currently waiting in https://github.com/forrestguice/NaturalHour/pull/27. I'll try to tag that release soon.

forrestguice commented 3 days ago

v0.2.3 is now available. 🌞

btw, this issue was closed automatically - can you verify that its actually fixed?