search

forrestguice / SuntimesWidget

Android app (and widget collection) that displays sunlight and moonlight times.
GNU General Public License v3.0
348 stars 61 forks source link

widget labels are not localized (fails to override locale) #200

Open forrestguice opened 6 years ago

forrestguice commented 6 years ago

Tested using v0.8.1 w/ api15, api19, and api25. The bug is in all versions. Some of the widget labels fail to localize despite having fully translated strings. Note that other parts of the app correctly localize these strings.

To reproduce.. 1) Navigate to Settings->Language Settings .. change the language to user-defined. 2) Select a language w/ a complete translation (e.g. Basque, German, Esperanto, or Polish). 4) Add a 2x1 moon widget to the homescreen; check "Show Labels". 5) Observe the new widget - its fully localized except for the label (moon phase text). 6) Resize the widget; the problem is also apparent in the 1x1 moon widgets and 3x1 moon widget.

The bug doesn't occur when the locale is set at the OS level (only the override behavior is affected).

forrestguice commented 6 years ago

The bug doesn't affect all labels, only the ones defined in the xml layout. Other text (that is assigned w/ setText) is correctly localized. It seems that the widgets do not fully override the locale - while the Resources (strings) are localized, the layouts are not.

The app doesn't currently provide any right-to-left languages, but supposing it did, I think this would also be broken for the same reason.