search

forrestguice / SuntimesWidget

Android app (and widget collection) that displays sunlight and moonlight times.
GNU General Public License v3.0
351 stars 61 forks source link

SunPositionWidget(3x1) or LightMap(3x1) custom alignment #471

Open Elpuma opened 3 years ago

Elpuma commented 3 years ago

Hello guys, I found this project 1 day ago and it is amazing! Kudos to the contributors, I will never end thanking your for such an amazing invention.

I want to personalize or enable a personalization option for the Day/Night drawing/widget to begin the day at sunrise, I always found illogical the old convention to start the day at midnight, so I wanted it to be in the same direction as my non-so-common non-orthodox personal point of views. Programming-wise I don't have a lot of experience but I'm really persistent so I believe I can do it, or, someone more savvy can do it and We all can enjoy.

I have a couple of hours experimenting with the source code and I'm yet to find the specific section that handles the drawing for the aforementioned section but If someone can guide me or give me a hint so I can look on a more concrete section that would be awesome. From this: image

to this: image

Thanks again.

EDIT: I found the "Natural Hour Addon" and was able to migrate the logic to the horizontal SunPosition Widget, I'm trying to solve some glitches.

forrestguice commented 3 years ago

Hi, thanks the praise. :) This is a personal project of mine. I've been very fortunate to have it translated into so many languages, and to reach such a wide audience.

I'm also interested in non-orthodox perspectives on time. I was going to point you to the "Natural Hour" app (but it seems you found it). Its my latest "exploration" and really similar to the mentioned "lightmap" widget.

I like the suggestion for a custom alignment. Its currently aligned by timezone (which has drawbacks) - I'm thinking there should be options to align by sunrise, sunset, or solar noon. Improving this graph has been on list for awhile. I'll include this in the next minor version (v0.14.0).

In the meantime you can tinker with it to make it do what you want (however please be aware that I'm not soliciting pull requests - I'll implement this). The code that draws the lightmap is located in LightMapView.java, within LightMapTask (inner class).

This is older code thats limited in some annoying ways. It draws the twilights for a single day as a series of overlapping rectangles scaled to the dimensions of the bitmap. Most of that code deals with numerous edge cases that occur at far north/south latitudes. I'll need to rewrite it to do custom alignment properly, but I was thinking one way to hack the current code is to offset the graph by some amount of time (same effect as configuring to the wrong timezone).

Elpuma commented 3 years ago

Hello Forrest! Thanks for replying! you sound like a really cool guy!! I'm not at expert at all, I will never dare to do a pull request, I'm just a person who enjoys tinkering thinks and learn as much as I can!

Thank you so much to include it in your future updates, I have a working version right now with everything hardcoded though, but I'm super excited to see your implementation and learn from you!

Thank you infinitely once again! Have an amazing day and may the peace be with you! ~Jose