search

forrestguice / SuntimesWidget

Android app (and widget collection) that displays sunlight and moonlight times.
GNU General Public License v3.0
326 stars 61 forks source link

[Bug Report] "Sun Position" screen altitude has the wrong colour during Nautical/Astronomical Twilight #805

Closed elydpg closed 3 weeks ago

elydpg commented 2 months ago

Describe the bug Pretty much the title

To Reproduce

  1. Open the app and click on "Sun Position" from the hamburger menu. Make sure the current location has nautical and astronomical twilight
  2. Advance until the altitude is between -6 and -12 degrees
  3. Note the colour of the altitude text
  4. Advance until the altitude is between -12 and -18 degrees
  5. Note the colour of the altitude text

Expected behavior Altitude text should be medium blue between -6 and -12 degrees and dark blue between -12 and -18 degrees

Screenshots

Civil Twilight (working as intended):

Screenshot_20240612-200845_Suntimes

Nautical Twilight

Screenshot_20240612-200910_Suntimes

Astronomical Twilight

Screenshot_20240612-200921_Suntimes

Version Info:

forrestguice commented 2 months ago

IIRC, it was originally as you described, but the contrast of the nautical/astronomical colors in dark mode was very poor. The quick fix at the time was to replace these colors (with gray) to make it readable.

I plan to make the colors consistent again in v0.16.0. I think to fix contrast issues, it will underline the field in a given color instead.