forrestguice / SuntimesWidget

Android app (and widget collection) that displays sunlight and moonlight times.
GNU General Public License v3.0
348 stars 61 forks source link

[Bug] - Begin of a major moon phase in the moon dialog shows two different times, depending on the row #843

Open suntimer24 opened 5 days ago

suntimer24 commented 5 days ago

Describe the bug See title of the issue.

To Reproduce Open the main app. Open the moon dialog. See the date and time for any major phase in the second row. Tip on the actual moon pahse in the first row and go to that date and time of the moon phase you choosed in the second row. Result: the date is identically, but time is differs.

Expected behavior Same date and time in both rows.

Screenshots Bug_Moondialog_001 Bug_Moondialog_002

Version Info:

Additional context Notice that it shows "Waning Gibbous" instead of "Full Moon". That is some super strange behaviour caused like this: The power button on my device is broken, so I can not take screenshots. But I can record a video of my screen and then make a screenshot of a part of that video while playing it. As soon as I start the record, the app switching from displaying "Full Moon" to "Waning Gibbous". Don't ask me why! Anyway, nothing else is changing and the bug was noticed while I was not recording, so just ignore that is does not show "Full Moon". ;)

"Add any other information about the problem here.

forrestguice commented 2 days ago

I've been testing this by tapping a major phase, then View Date -> Moon, and then using the > and < controls.

The label in the first row is simply wrong, but the times given in the second row are the correct major phase dates. After reviewing the code, it seems the first row is showing a "daily label" (as shown on main card), which doesn't get updated when stepping > or <.

I think the expected behavior is that the label changes from one minor phase to the next at the time of each major phase. e.g. from waxing to waning gibbous. Since the major phases are instants, their labels wouldn't normally be shown.