search

forrestkirby / herzogdupont-joomla

Herzog Dupont is an extension which adds more elements to the YOOtheme Pro page builder developed by YOOtheme.
https://herzog-dupont.de/yootheme-pro
GNU General Public License v3.0
19 stars 7 forks source link

Prefix for HD Counter #39

Open ibweb opened 1 year ago

ibweb commented 1 year ago

The current HD counter only allows the Unit to be displayed after the number. This does not work well for USA companies that need to list the dollar sign $ before the number.
Please allow an option to select the Unit to be a prefix or suffix.

Also, we should have the ability to remove the space between the unit and the number.

As an alternate, and perhaps even better, implementation method, it might actually be better to have a prefix unit/symbol field instead. That way you can leave the "Unit" field as it is currently, but also allow users to have both prefix and suffix. For instance, this would allow a string like "$25,000+" to be present.

Thank you in advance for considering this feature request. We love your plugin!

forrestkirby commented 1 year ago

Please see https://github.com/forrestkirby/herzogdupont-joomla/commit/8b5f5b9de93a6709f0e5d00364a874403da364f4

ibweb commented 1 year ago

@forrestkirby The prefix works wonderfully! However, the "Remove the space character between the prefix and the number" options removes one space. It looks like the counter element by default puts two spaces in between the number and the character. When we enable remove space, it removes only one of the two. As such, that needs to be reconfigured to remove two spaces, not one. I apologize for missing that on my end when I originally wrote up the Issue.

forrestkirby commented 1 year ago

Thanks for testing. I didn’t notice this either and found out that the additional spaces are actually added by the browser if you have line breaks between span elements. This should be fixed with https://github.com/forrestkirby/herzogdupont-joomla/commit/6951a19be5c992b642227c20320a16520d177738. Please try the latest version of the branch https://github.com/forrestkirby/herzogdupont-joomla/tree/feature-counter-prefix.

ibweb commented 1 year ago

@forrestkirby I tried the latest version of the branch, and while that fixed the spaces it caused a weird alignment issue for both counters that do and counters that do not use the prefix. See the screenshot below: weird-formatting

ibweb commented 1 year ago

@forrestkirby any luck fixing the above issue?

ibweb commented 1 year ago

@forrestkirby we really need this finalized soon. Have you been able to fix the above issue we reported?

ibweb commented 1 month ago

@forrestkirby did this get addressed in any of your updates?