search

forrtproject / forrtproject.github.io

FORRT Website
https://forrt.org
Other
31 stars 18 forks source link

Reducing reviews required for a PR from 1 to 2 for content folder #146

Closed flavioazevedo closed 2 months ago

flavioazevedo commented 2 months ago

We should probably discuss the several changes in how the website works in detail sometime after the summer, but I would like to request for the moment that only one review is necessary to facilitate the speed with which we are able to fix bugs on the website for content changes, add content, remove wrong info, add talks and partnerships, etc.

See, for example, this case where a forrt member is unable to use FORRT glossary in their training, and this is time-sensitive, and there are folks willing work on the weekend to fix the issue:

https://forrt.slack.com/archives/CM6344P5E/p1720808081180659?thread_ts=1720808081.180659&cid=CM6344P5E

bethaniley commented 2 months ago

This message has been moved over to #136 to remove repetition.

TL;DR: Potentially there's a workaround where markdown files could be allocated one reviewer, and technical changes (e.g. to Python or YAML scripts) can be kept as two reviewers. The latter needs two reviews to prevent "looks good to me" approvals, which have been very common in previous PRs.

bethaniley commented 2 months ago

Duplicate issue with #136