search

forrtproject / forrtproject.github.io

FORRT Website
https://forrt.org
Other
31 stars 18 forks source link

Update CODEOWNERS and introduce a new team #155

Open DAKiersz opened 2 months ago

DAKiersz commented 2 months ago

In response to https://github.com/forrtproject/forrtproject.github.io/issues/136

According to (1), "the last matching pattern takes the most precedence". Therefore, if technical changes are being introduced, FORRT Engineering will take precedence over Team Website. This change will allow to get the right people to review changes on the website. The more complicated/technical the changes are, the more expertise a review will need to merge it to main.

In layman's terms, this will allow a simple content change to be reviewed by Team Website and ensure that more technical changes will require a stricter review. As a result, this should be enough to justify returning to a 1 reviewer system to increase the velocity of changes.

I'm open to code suggestions if we can improve this further.

Testing

Example Effect

PRs like #156 that consisted of a simple .md file change would only need a member of Team Website to approve.

References

(1) https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners (2) https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams

Please do not merge this before I can perform checks.

helenahartmann commented 2 months ago

I would appreciate if we (the IOI team and team website contributors) have a meeting to discuss this before any further actions are taken or this is approved.

bethaniley commented 2 months ago

Hey @helenahartmann! I haven't called an IOI meeting yet because my availability is really variable until I submit my thesis in late September.

This PR is a proposal for one way to manage the review process. Any feedback/suggestions are very welcome as comments here! 🙂

helenahartmann commented 2 months ago

Hi Bethan!

My understanding is that the IOI grant and website changes have started quite a while ago but there has not been a single meeting with all five of us in it. I have also never been informed by you, Flavio or the other grantees what is happening with the grant and what my role is.

I feel like these changes are things we should discuss as a team before we do them, over Zoom and not on a GitHub PR directly during the implementation of those changes. I also strongly feel like if there's time to implement all these changes, there should definitely be time for a meeting, if not regular ones, so we can make decisions as a team.

I fully understand that you currently don't have time for this because of PhD craziness, but then maybe we should stop any active changes and wait until we all have time to meet? What do you and others think?

Best, Helena

On Mon, 29 Jul 2024, 17:49 Bethan Iley, @.***> wrote:

Hey @helenahartmann https://github.com/helenahartmann! I haven't called an IOI meeting yet because my availability is really variable until I submit my thesis in late September.

This PR is a proposal for one way to manage the review process. Any feedback/suggestions are very welcome as comments here! 🙂

— Reply to this email directly, view it on GitHub https://github.com/forrtproject/forrtproject.github.io/pull/155#issuecomment-2256286657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHQL446ULXHW2EK2TK42JCDZOZP7PAVCNFSM6AAAAABLS7AGNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGI4DMNRVG4 . You are receiving this because you were mentioned.Message ID: @.***>

bethaniley commented 2 months ago

Hi Helena! Not going to lie, I meant feedback on the PR rather than project management, which is probably something which should be addressed in direct messages 😅 But I can address your points here if that's easier!

My understanding is that the IOI grant and website changes have started quite a while ago but there has not been a single meeting with all five of us in it. I have also never been informed by you, Flavio or the other grantees what is happening with the grant and what my role is. I feel like these changes are things we should discuss as a team before we do them, over Zoom and not on a GitHub PR directly during the implementation of those changes. I also strongly feel like if there's time to implement all these changes, there should definitely be time for a meeting, if not regular ones, so we can make decisions as a team.

I think the first thing to note is that we only started working on this on 30th May and received the grant on 5th July. I've also been a bit limited in capacity for multiple reasons beyond just the PhD this month (e.g. behind-the-scenes FORRT stuff), so that's probably where the communication fell short, and I'm very sorry for that.

At present, myself and @DAKiersz are working through an audit of the website. As we've been going through the audit, Dom and I found some easy wins which don't change much about how the website functions and make contributing easier/more consistent. These are the pull requests with the "IOI grant" tag, plus a few changes on the GitHub side which are in line with FORRT's already existing processes (resources require review -> pull requests require review & don't directly edit resources -> don't push to main). We've also set up a funky project board for Team Website generally to keep track of to-dos 😎

We're working through the audit until end of September (which is roughly in line with the original four-month plan). When it's done we'll discuss the findings/recommendations and work out roles regarding implementation. You've not heard much because there isn't much to say yet, but there will be soon!

I fully understand that you currently don't have time for this because of PhD craziness, but then maybe we should stop any active changes and wait until we all have time to meet? What do you and others think?

Do you mean any active changes on the website at all? I don't think that's feasible unfortunately. Richard and Lukas have also regularly been making changes - some of which overlap with the grant, e.g. #134

helenahartmann commented 2 months ago

That's exactly my point. If the grant has started 30th of May that means the grant and its activities are running since 2 maybe months without ever having any team meeting. I would appreciate one before any IOI related activities commence, i.e. the audit. Even easy changes we should discuss as a team, as FORRT usually does.

Regarding changes to the website in general, I think content changes are completely fine to continue doing as they've been done before. It is the audit/IOI related stuff I would like to know more about before it continues. I believe a meeting, even a short one, with all IOI people, is critical. That should be the priority now, in my opinion as a grant participant.

On Mon, 29 Jul 2024, 21:37 Bethan Iley, @.***> wrote:

Hi Helena! Not going to lie, I meant feedback on the PR rather than project management, which is probably something which should be addressed in direct messages 😅 But I can address your points here if that's easier!

My understanding is that the IOI grant and website changes have started quite a while ago but there has not been a single meeting with all five of us in it. I have also never been informed by you, Flavio or the other grantees what is happening with the grant and what my role is. I feel like these changes are things we should discuss as a team before we do them, over Zoom and not on a GitHub PR directly during the implementation of those changes. I also strongly feel like if there's time to implement all these changes, there should definitely be time for a meeting, if not regular ones, so we can make decisions as a team.

I think the first thing to note is that we only started working on this on 30th May and received the grant https://opencollective.com/ioi-website-project/contributions/774509 on 5th July. I've also been a bit limited in capacity for multiple reasons beyond just the PhD this month (e.g. behind-the-scenes FORRT stuff), so that's probably where the communication fell short, and I'm very sorry for that.

At present, myself and @DAKiersz https://github.com/DAKiersz are working through an audit of the website. As we've been going through the audit, Dom and I found some easy wins which don't change much about how the website functions and make contributing easier/more consistent. These are the pull requests with the "IOI grant" tag, plus a few changes on the GitHub side which are in line with FORRT's already existing processes (resources require review -> pull requests require review & don't directly edit resources -> don't push to main). We've also set up a funky project board https://github.com/orgs/forrtproject/projects/1 for Team Website generally to keep track of to-dos 😎

We're working through the audit until end of September (which is roughly in line with the original four-month plan). When it's done we'll discuss the findings/recommendations and work out roles regarding implementation. You've not heard much because there isn't much to say yet, but there will be soon!

I fully understand that you currently don't have time for this because of PhD craziness, but then maybe we should stop any active changes and wait until we all have time to meet? What do you and others think?

Do you mean any active changes on the website at all? I don't think that's feasible unfortunately. Richard and Lukas have also regularly been making changes - some of which overlap with the grant, e.g. #134 https://github.com/forrtproject/forrtproject.github.io/pull/134

— Reply to this email directly, view it on GitHub https://github.com/forrtproject/forrtproject.github.io/pull/155#issuecomment-2256753809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHQL445IL6DA6HLK6K5RFKDZO2KZLAVCNFSM6AAAAABLS7AGNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWG42TGOBQHE . You are receiving this because you were mentioned.Message ID: @.***>

DAKiersz commented 2 months ago

To briefly comment on the website activities. As @bethaniley said, there have been more than content changes being introduced shortly after the grant began, even by people outside of the IOI grant. Lack of meetings should not grind development to a halt, in what effectively is an open source project that can be managed in issues and PRs when time is sparse. Development is an iterative process, and there is no harm in proposing relatively small changes and having them reviewed collaboratelly as myself, Lukas W and Richard D have done. The latter should really be celebrated as a resurgence of activities on the website!

Having said that, this discussion is straying a bit outside the scope of this PR. FORRT related issues would be best to be addressed on Slack.