search

forrtproject / forrtproject.github.io

FORRT Website
https://forrt.org
Other
28 stars 16 forks source link

Preview Url on every PR #98

Closed richarddushime closed 2 months ago

richarddushime commented 2 months ago

In this PR i am looking forward to add a preview link to each and every PR i created a site on netlify using my fork (just for demonstration) If we are to use master branch there is some changes that should be done because using the master branch i was getting an error in builds then i updated the requirement.txt numpy version from 1.25.1 which seems not to exist to 1.24.4 lts

@SamGuay would you be having an idea on how this can be implemented in otherways ? it would be good to have on the main repos As its done here

In progress

SamGuay commented 2 months ago

If I am not mistaken, we still have the Netlify mechanic working. Might just be a question of re-enabling it. However, we've got a bunch of GitHub actions doing their things before building the site. Maybe the best way forward would be to build the the website using netlify but from another branch post-GHA?

flavioazevedo commented 2 months ago

Reminder: we also changed from Netlify to GH because there were issues there (different ones but still worth the reminder). Given this, I would be include to find a way to fix it in GH rather than shifting to netlify (especially given all the automations!)