search

forsaken1 / activeadmin-latlng

Active Admin plugin for setting up latitude and longitude
https://rubygems.org/gems/activeadmin_latlng
MIT License
37 stars 19 forks source link

https instead of http requests to fix 'Mixed Content' issue #22

Closed Hossam-Hawary closed 5 years ago

Hossam-Hawary commented 5 years ago

On production, we force https and making such requests to load the assets needed get blocked by the browser due to Mixed Content policy modified: lib/activeadmin/views/openstreetmap_proxy.rb modified: lib/activeadmin/views/templates/openstreetmap.html.erb

codecov-io commented 5 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files           6        6           
  Lines          27       27           
=======================================
  Hits           23       23           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d76bb6...2406ef3. Read the comment docs.

forsaken1 commented 5 years ago

@Hossam-Hawary thank you!

forsaken1 commented 5 years ago

@Hossam-Hawary updated: https://rubygems.org/gems/activeadmin_latlng/versions/1.4.0

Hossam-Hawary commented 5 years ago

@Hossam-Hawary updated: https://rubygems.org/gems/activeadmin_latlng/versions/1.4.0

Thanks to you @forsaken1